Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/3101 a11y startup at configModel:dataLoaded #3102

Merged
merged 1 commit into from
Mar 24, 2021
Merged

issue/3101 a11y startup at configModel:dataLoaded #3102

merged 1 commit into from
Mar 24, 2021

Conversation

oliverfoster
Copy link
Member

fixes #3101

Fixed

  • a11y api now starts up at configModel:dataLoaded instead of app:dataLoaded

@oliverfoster oliverfoster self-assigned this Mar 23, 2021
moloko
moloko approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@moloko moloko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code 👓 plus a very quick check in Edge with Jaws 2021 plus Firefox & IE11 (no screen reader)

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

tomgreenfield
tomgreenfield approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@tomgreenfield tomgreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️

@tomgreenfield tomgreenfield merged commit 6ba5a77 into master Mar 24, 2021
@tomgreenfield tomgreenfield deleted the issue/3101 branch March 24, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@moloko moloko moloko approved these changes

@tomgreenfield tomgreenfield tomgreenfield approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adapt_framework: load a11y after config, not course load
4 participants
@oliverfoster @tomgreenfield @moloko @cahirodoherty-learningpool