Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/2758 Added deepClone API (v5.7.0) #2759

Merged
merged 73 commits into from
Jul 16, 2020
Merged

issue/2758 Added deepClone API (v5.7.0) #2759

merged 73 commits into from
Jul 16, 2020

Conversation

olivermartinfoster
Copy link
Contributor

@olivermartinfoster olivermartinfoster commented May 9, 2020 •
edited by oliverfoster
Loading

#2758

Added

  • AdaptModel.deepClone to clone model hierarchies

Changed

  • Adapt.findById Moved indexing to add/remove events in data collection rather than indexing after file download
  • AdaptModel.setupModel Stopped running on the adapt:initialize event but instead is called after cloned or on instantiation after file download
  • Allowed QuestionModel to restoreUserAnswers after clone without having to listen to the adapt:initialize event
  • Changed the order of init execution in ItemsQuestionModel such that ItemsComponentModel can setup its children before QuestionModel tries to restoreUserAnswers

oliverfoster and others added 30 commits March 31, 2020 17:03
@oliverfoster
issue/2709 Converted some classes to ES6 for future works
87a4534
@oliverfoster
issue/2709 fixed locking model for ES6 classes
80787b1
@oliverfoster
Recommendations
5a686db
@oliverfoster
Recommendations
603d332
@oliverfoster
Recommendations
c368971
@oliverfoster @tomgreenfield
Recommendation
ce81506 
Co-Authored-By: tomgreenfield <tomgreenfield@users.noreply.github.com>
@oliverfoster @tomgreenfield
Recommendation
6681597 
Co-Authored-By: tomgreenfield <tomgreenfield@users.noreply.github.com>
@oliverfoster
Recommendations
d50d146
@oliverfoster
issue/2712 Simplfied router
d4aad08
@oliverfoster
Fixed bugs added comments
8933d4e
@oliverfoster
Added defer to postRemove events as expected
0375144
@oliverfoster
Removed bad condition
4db8f12
@oliverfoster
Switched to cached value
068d28d
@oliverfoster @tomgreenfield
Recommendations
551d458 
Co-Authored-By: tomgreenfield <tomgreenfield@users.noreply.github.com>
@oliverfoster @tomgreenfield
Recommendations
4911dbb 
Co-Authored-By: tomgreenfield <tomgreenfield@users.noreply.github.com>
@oliverfoster
Recommendations
749353f
@oliverfoster
issue/2714 Decoupled menu, page, article, block and component
81cacf1
@oliverfoster
Typo
64274b7
@oliverfoster
Recommendations
2de000f
@oliverfoster
issue/2714: Added Adapt.log.warnOnce
1942b1a
@oliverfoster
Linting fixes
347f520
@oliverfoster
issue/2714 Added fallback model/view name discovery
96bda87
@oliverfoster
issue/2645 Added manifest creation and loading
ebdabc5
@oliverfoster
Fixed issue with new compatibility layer changes
dfb9224
@oliverfoster
issue/2712 Simplfied router
3b929b3
@oliverfoster
Fixed bugs added comments
df93b45
@oliverfoster
Added defer to postRemove events as expected
763ccfc
@oliverfoster
Removed bad condition
eb6597a
@oliverfoster
Switched to cached value
eca527b
@oliverfoster @tomgreenfield
Recommendations
5a1cae8 
Co-Authored-By: tomgreenfield <tomgreenfield@users.noreply.github.com>
@oliverfoster oliverfoster changed the base branch from release/v5.5.0 to release/v5.6.0 May 12, 2020 10:21
@oliverfoster oliverfoster changed the title issue/2758 Added deepClone API (v5.5.0) issue/2758 Added deepClone API (v5.6.0) May 12, 2020
@oliverfoster oliverfoster linked an issue May 12, 2020 that may be closed by this pull request
adapt_framework v5.7.0: Add model deepClone #2758
Closed
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

moloko
moloko approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@moloko moloko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code 👓

@oliverfoster oliverfoster changed the title issue/2758 Added deepClone API (v5.6.0) issue/2758 Added deepClone API (v5.7.0) Jun 17, 2020
@oliverfoster oliverfoster mentioned this pull request Jun 18, 2020
Merged
@oliverfoster oliverfoster changed the base branch from release/v5.6.0 to master July 7, 2020 17:48
oliverfoster and others added 6 commits July 15, 2020 17:12
@oliverfoster
issue/2758: Removed complexity
4768daa 
* Removed `set` and `setOnChildren` parameters for the `modifier` function only
* Allowed the `modifier` function to specify custom unique ids or default to assign unique ids automatically
* Switched the `modifier` function arguments so that the `cloned` model appears before the original, as its more useful that way
* Swapped the new unique id so that the original id is the prefix rather than the postfix, which will allow easier reading of cloned items in the dom and model collections
@oliverfoster
issue/2758 Rework parent attachments
87bb0f0
@oliverfoster
Typo
229d82a
@olivermartinfoster
Merge branch 'master' into issue/2758
390adb3
@olivermartinfoster
issue/2758 Recommendations and testing changes
a4d8dc3
@olivermartinfoster
issue/2758 Typo
6b12bf7
tomgreenfield
tomgreenfield approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@tomgreenfield tomgreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

moloko
moloko approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@moloko moloko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small suggestion, otherwise looks good

@oliverfoster oliverfoster merged commit 8c7ac76 into master Jul 16, 2020
@oliverfoster oliverfoster deleted the issue/2758 branch July 16, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomgreenfield tomgreenfield tomgreenfield approved these changes

@moloko moloko moloko approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@chetan-hajare chetan-hajare Awaiting requested review from chetan-hajare

Assignees

@olivermartinfoster olivermartinfoster

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adapt_framework v5.7.0: Add model deepClone
5 participants
@olivermartinfoster @tomgreenfield @moloko @cahirodoherty-learningpool @oliverfoster