Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added component padding variable #2679

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Added component padding variable #2679

merged 1 commit into from
Mar 9, 2020

Conversation

guywillis
Copy link
Contributor

Issue: #2676

  • Added new component horizontal padding variable.
  • Applied to component.less left / right padding

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@guywillis guywillis requested review from kirsty-hames and a user March 9, 2020 09:59
kirsty-hames
kirsty-hames approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@moloko moloko merged commit d30e556 into master Mar 9, 2020
@moloko moloko deleted the issue/2676 branch March 9, 2020 11:06
oliverfoster pushed a commit that referenced this pull request Mar 9, 2020
@guywillis @oliverfoster
Added component padding variable (#2679)
524d24e
oliverfoster pushed a commit that referenced this pull request Mar 9, 2020
@guywillis @oliverfoster
Added component padding variable (#2679)
72d59fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guywillis @kirsty-hames @oliverfoster @cahirodoherty-learningpool @moloko