issue/2662 Formalised plugin, data, schema and translate API #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jamesrea83
reviewed
Mar 3, 2020
jamesrea83
reviewed
Mar 3, 2020
|
Awaiting a framework release and a few more reviews before merging. |
|
This pr is ready for final +1s if anyone has the inclination. |
moloko
reviewed
Mar 11, 2020
| removeTrackingIds(blocksFiles[i], courseFiles[i]); | ||
| } | ||
|
|
||
| const data = Helpers.getFramework().getData(); |
There was a problem hiding this comment.
I know it's not part of your changes but I think the check for spoor in L4 should be removed.
There was a problem hiding this comment.
Will have a crack at this when I layout moving tracking ids from blocks to components.
I wanted to keep the behaviour here as close to identical with additions only for the moment.
tomgreenfield
approved these changes
Mar 11, 2020
chetan-hajare
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2662
Additions
grunt translate:importis extended with a new--test=trueparameter.Changes
Removed
Notes
The build tasks should carry on working as normal, this change should be non-breaking but should increase code clarity dramatically. It is necessary to formalise these in order to the move to v6.
Intellisense should work really nicely for the new API in at least VSCode.
If you want to debug grunt you can use grunt-brk and chrome://inspect.