fixes issue/2642 adds package-lock with less 3.10.3 #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moloko
approved these changes
Feb 10, 2020
canstudios-nicolaw
approved these changes
Feb 10, 2020
cahirodoherty-learningpool
approved these changes
Feb 10, 2020
|
@oliverfoster Should this include the package.json now that LESS has been updated there? |
|
Nah, this package-lock file will need to be overwritten before the next release anyway. You can see this pr more as an acceptance of the package-lock prinicple rather than approval for what's in the package-lock file.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2642