issue/1521: remove navigation from #wrapper #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lc-thomasberger
approved these changes
Apr 12, 2017
moloko
approved these changes
Apr 14, 2017
guywillis
approved these changes
May 8, 2017
|
@moloko, isn't the re-positioning of the navigation a bit of a breaking change, for themes at least? I'm mentioning this in case our next version should be 2.1.0 rather than 2.0.20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #1521
course._navigation._isDefaultNavigationDisablednavigation:initializeevent for navigation bar plugins to know when to start#wrapperlocation classes onhtmltag to allow styling of navigation as usual.navigationcontainer before the#wrapperdiv so that the tab order is preserved