jquery.a11y tabindex fix #1092
Merged
jquery.a11y tabindex fix #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove tabindex from hideable elements on popdown
|
+1 |
| $item.removeAttr('aria-hidden').removeClass("aria-hidden"); | ||
|
|
||
| if ($item.is(domSelectors.hideableElements)) { | ||
| $item.removeAttr("tabindex"); |
There was a problem hiding this comment.
CODE NOTES
.a11y-hideable
Some elements, which were never explicitly in the tab order, need to be removed from the tab order when a popup occurs. Label tags associated with input tags are an example of such elements. When the popdown occurs their tabindex="0" should be removed as it wouldn't have originally existed and will cause a double tab if left.
iFrame containers for youtube videos will also have this same problem.
|
+1 |
1 similar comment
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove tabindex from hideable elements on popdown