Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt_framework: doesn't always prevent buttons with aria-disabled from being clicked #3097

Closed
moloko opened this issue Mar 22, 2021 · 0 comments · Fixed by #3100
Closed
Assignees

Comments

@moloko
Copy link
Contributor

moloko commented Mar 22, 2021

If the button contains an inner element - for example a <div> wrapping the text label - clicking that element will trigger the button's click event anyway.

Need to amend this function to get it to check parents as well.

Additionally, that code doesn't seem to be initialising during the initial display of the language picker. Might be easiest just to change those to use the disabled attribute since I don't think it's really the end of the world if screenreader users are unaware of the existence of languages that aren't yet available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant