Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement/themeRefactor - 'grunt dev' device size defaults #2153

Closed
guywillis opened this issue Jul 3, 2018 · 1 comment
Closed

enhancement/themeRefactor - 'grunt dev' device size defaults #2153

guywillis opened this issue Jul 3, 2018 · 1 comment

Comments

@guywillis
Copy link
Contributor

guywillis commented Jul 3, 2018 •
edited
Loading

I have changed the default large / medium / small device width dimensions from being px based (900 / 760 / 520) to em based (56.25 / 47.5 / 32.5) as part of the theme refactor.

As a consequence, I have encountered a bug with the grunt dev command whereby if I amend a .json file then the defaults revert back to the px based values even though I have updated the defaults in configModel.js and theme.json to be em based.

image
@oliverfoster
Copy link
Member

To reproduce

  1. Edit json save,
  2. Edit less, save
  3. ????
  4. Bug

@oliverfoster oliverfoster mentioned this issue Aug 23, 2018
Merged
oliverfoster added a commit that referenced this issue Oct 3, 2018
@oliverfoster
issue/#2153 screen size defaults (#2218)
43e7ce0 
* issue/#2153 fixed glob declarations

* issue/#2153 remove unneeded console logs

* Minor: Corrected spacing on variable placeholders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliverfoster @guywillis