Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/2818 #262

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Issue/2818 #262

merged 2 commits into from
Jul 7, 2020

Conversation

guywillis
Copy link
Contributor

Resolves adaptlearning/adapt_framework#2818

Addresses:

  • Set up example multi language / multi font support (when uncommented)
  • Change language drawer buttons now appear in target language (when uncommented)
  • Change language notify confirmation pop up now appears in target language (when uncommented)

guywillis added 2 commits June 29, 2020 14:45
@guywillis
Set up example language specific font override
6337982
@guywillis
Sets up example language picker override fixes
ce0f3e3 
For language picker drawer item and notify confirmation pop up.

Sets button / pop up to appear in target language font rather than current language font.
kirsty-hames
kirsty-hames approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 5547c57 into master Jul 7, 2020
@oliverfoster oliverfoster deleted the issue/2818 branch July 7, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moloko moloko moloko approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster Awaiting requested review from oliverfoster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adapt-contrib-languagePicker - Change language drawer items and notify confirmation pop up in wrong fonts
5 participants
@guywillis @moloko @kirsty-hames @cahirodoherty-learningpool @oliverfoster