issue/2747 Added _attemptStates save and restore #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2747
Requires #2748 to framework for testing.
Built atop of #190, the old question state serialiser couldn't handle the more complicated data structure.
Changed
_isResetOnRevisit = truthyare saved as attempt states can be more useful here. The new serialiser is much more efficient and stable and is able to capture this new information and store all of the current and new data in a smaller suspend data footprint.Added
_attemptStatesattributes across sessions_spoor._tracking.__shouldStoreAttempts = falsetoconfig.jsonto control when attempt states are saved and restored. Attempt states are not saved and restored by default.