Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Updated focus to focus-visible (fixes #231) #274

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Update: Updated focus to focus-visible (fixes #231) #274

merged 1 commit into from
Dec 7, 2022

Conversation

guywillis
Copy link
Contributor

Fixes: #231

Update

  • Converted :focus to :focus-visible

@guywillis guywillis self-assigned this Dec 1, 2022
joe-allen-89
joe-allen-89 reviewed Dec 5, 2022
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another :focus in accessibility.less which may also need changing.

@StuartNicholls
Copy link
Contributor

There's another :focus in accessibility.less which may also need changing.

@joe-allen-89 This is a global override for ALL :focus pseudo elements so should remain as is.

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 03577bf into master Dec 7, 2022
@oliverfoster oliverfoster deleted the issue/231 branch December 7, 2022 15:14
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

🎉 This PR is included in version 6.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 left review comments

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@StuartNicholls StuartNicholls StuartNicholls approved these changes

@eleanor-heath eleanor-heath Awaiting requested review from eleanor-heath

@kirsty-hames kirsty-hames Awaiting requested review from kirsty-hames

Assignees

@guywillis guywillis

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Look at focus-visible
5 participants
@guywillis @StuartNicholls @oliverfoster @cahirodoherty-learningpool @joe-allen-89