Fix: respect locked content when returning to location (fixes #51) #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
oliverfoster
approved these changes
Jun 19, 2024
|
Would you mind commenting on why |
|
@oliverfoster sorry I misinterpreted the way trickle would lock - have removed offset |
Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
oliverfoster
approved these changes
Jun 19, 2024
lemmyadams
approved these changes
Jun 20, 2024
ethan-lp
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#51
Fix
Notes
If the bookmark is of type contentobject and the location is locked or preceded by locked content then the user is returned to the nearest unlocked contentobject prior to the location.
If the bookmark is of type article/block/component and the location is preceded by locked content then the user is returned to the nearest point prior to the location that is not itself preceded by locked content.