Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/2763 Updated to use Adapt.navigateToElement (v5.7.0) #38

Merged
merged 2 commits into from
Aug 21, 2020
Merged

issue/2763 Updated to use Adapt.navigateToElement (v5.7.0) #38

merged 2 commits into from
Aug 21, 2020

Conversation

olivermartinfoster
Copy link
Contributor

@olivermartinfoster olivermartinfoster commented May 10, 2020 •
edited by moloko
Loading

fixes #2763

Part of #2760

Changed

  • Updated to use Adapt.navigateToElement to ensure views are rendered before returning the user to them
  • Bumped framework dependency to v5.6

Requires #2761

@olivermartinfoster olivermartinfoster self-assigned this May 10, 2020
@olivermartinfoster olivermartinfoster changed the title issue/2763 Updated to use Adapt.navigateToElement issue/2763 Updated to use Adapt.navigateToElement (v5.5.0) May 10, 2020
@olivermartinfoster olivermartinfoster mentioned this pull request May 10, 2020
Closed
@oliverfoster oliverfoster changed the title issue/2763 Updated to use Adapt.navigateToElement (v5.5.0) issue/2763 Updated to use Adapt.navigateToElement (v5.6.0) May 12, 2020
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster
Copy link
Member

Awaiting adaptlearning/adapt_framework#2761

@oliverfoster oliverfoster changed the title issue/2763 Updated to use Adapt.navigateToElement (v5.6.0) issue/2763 Updated to use Adapt.navigateToElement (v5.7.0) Jun 22, 2020
@oliverfoster oliverfoster merged commit 5c8331f into master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moloko moloko moloko approved these changes

@chetan-hajare chetan-hajare chetan-hajare approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@tomgreenfield tomgreenfield Awaiting requested review from tomgreenfield

Assignees

@olivermartinfoster olivermartinfoster

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adapt-contrib-bookmarking v5.7.0: Update to Adapt.navigateToElement
5 participants
@olivermartinfoster @oliverfoster @moloko @chetan-hajare @cahirodoherty-learningpool