Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/2756 Reduced suspend data usage #125

Merged
merged 7 commits into from
Aug 20, 2020
Merged

issue/2756 Reduced suspend data usage #125

merged 7 commits into from
Aug 20, 2020

Conversation

olivermartinfoster
Copy link
Contributor

@olivermartinfoster olivermartinfoster commented May 9, 2020 •
edited by oliverfoster
Loading

#2756

Changed

  • Reduced suspend data usage using Adapt.offlineStorage.serialize and Adapt.offlineStorage.deserialize
  • Bumped framework dependency to v5.4.*

Requires #193 and #2757

@olivermartinfoster olivermartinfoster self-assigned this May 9, 2020
@olivermartinfoster olivermartinfoster mentioned this pull request May 10, 2020
Closed
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@cahirodoherty-learningpool
Copy link
Contributor

Minor comment: I'm assuming you will be running a lint on these files after this initial, functional PR. Just noticed some mixing of var/let/const.

@oliverfoster
Copy link
Member

oliverfoster commented May 28, 2020 •
edited
Loading

@cahirodoherty-learningpool
I'm not intending to rewrite assessment to es6+ in this PR, just wanted this to be a feature/enhancement addition. I can do that in a separate pr afterwards if that's alright?

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster mentioned this pull request Jun 18, 2020
Merged
2 tasks
tomgreenfield
tomgreenfield approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@tomgreenfield tomgreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️

js/adapt-assessmentArticleModel.js Show resolved Hide resolved
@oliverfoster oliverfoster mentioned this pull request Aug 12, 2020
Closed
lc-alexanderbenesch
lc-alexanderbenesch approved these changes Aug 19, 2020
View reviewed changes
Copy link

@lc-alexanderbenesch lc-alexanderbenesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit 8fa7a4f into master Aug 20, 2020
@oliverfoster oliverfoster deleted the issue/2756 branch August 20, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomgreenfield tomgreenfield tomgreenfield approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@lc-alexanderbenesch lc-alexanderbenesch lc-alexanderbenesch approved these changes

@chetan-hajare chetan-hajare Awaiting requested review from chetan-hajare

@moloko moloko Awaiting requested review from moloko

Assignees

@olivermartinfoster olivermartinfoster

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@olivermartinfoster @cahirodoherty-learningpool @oliverfoster @tomgreenfield @moloko @lc-alexanderbenesch