You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Good catch, do you have an example VIN with a 2-character WMI I can add a unit test for? The VIN must still be 17 characters long, so I want to make sure I've accounted for the padding byte in the right place.
Ok, I found an example from Toyota. In this case, the WMI doesn't change from 3 characters, it's just that the manufacturer ID is encoded in the first 2 characters and the 3rd is used to encode the vehicle type. I've added a fallback now so that if the full 3-char lookup fails, we try again with the 2nd. I'll include this in a 0.2.1 release to be pushed out soon. Thanks again for the report!
Some manufacturers use the first 2 characters of the WMI as the
manufacturer ID, with the 3rd denoting the specific class of vehicle
specific to that manufacturer.
Fixes#7.
Hi. Thanks for the package
I noticed the "wmi" is the first 3 characters of the vin number after normalization.
But some of the brands' wmi is 2-characters, like Nissan(1N), in manufacturers map.
'1N': 'Nissan',
So the getManufacturer() function will return "Unknown"
The text was updated successfully, but these errors were encountered: