forked from magento/magento2
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nx work new #11
Open
adamzero1
wants to merge
14
commits into
nx-work
Choose a base branch
from
nx-work-new
base: nx-work
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Nx work new #11
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
dddc7aa
work
adamzero1 2c951e5
work
adamzero1 8fe2589
work
adamzero1 6a28e09
work
adamzero1 ab8d3cb
work
adamzero1 4045fe7
fix: right to left mark
adamzero1 83172fc
fix: currency conversion
adamzero1 5f8feb7
removing debug
adamzero1 86b7334
removing debug
adamzero1 f20a4fc
work
adamzero1 242201d
work
adamzero1 d935516
aaaaa
adamzero1 eb015ae
aaaa
adamzero1 2b7b972
debug: testing workflow
adamzero1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| name: Unit Tests | ||
| run-name: ${{ github.actor }} is running Unit Tests | ||
| on: | ||
| pull_request: | ||
| branches: | ||
| - 2.4-develop | ||
| - nx-work | ||
|
|
||
| permissions: | ||
| contents: write | ||
|
|
||
| jobs: | ||
| run-unit-tests: | ||
| uses: adamzero1/mage-os-infrastructure/.github/workflows/unit-tests.yml@nx-unit-testing | ||
|
|
||
| # name: Unit Tests | ||
| # run-name: ${{ github.actor }} is running Unit Tests | ||
| # on: | ||
| # pull_request: | ||
| # branches: | ||
| # - 2.4-develop | ||
| # - nx-work | ||
|
|
||
| # permissions: | ||
| # contents: write | ||
|
|
||
| # jobs: | ||
| # unit-tests: | ||
| # strategy: | ||
| # fail-fast: false | ||
| # matrix: | ||
| # php_version: [8.1,8.2] | ||
| # runs-on: ubuntu-latest | ||
| # steps: | ||
| # - name: Checkout PR commit | ||
| # uses: actions/checkout@v3 | ||
| # with: | ||
| # ref: ${{ github.event.pull_request.head.sha }} | ||
| # path: main | ||
| # # Need to do this otherwise Nx cant determine diff | ||
| # fetch-depth: 0 | ||
|
|
||
| # - name: Fetch base | ||
| # working-directory: ./main | ||
| # run: git fetch origin ${{ github.event.pull_request.base.ref }} | ||
|
|
||
| # - name: Install Composer | ||
| # uses: php-actions/composer@v6 | ||
| # with: | ||
| # # Run the dummy help command after installing Composer (otherwise defaults to install) | ||
| # command: help | ||
|
|
||
| # - name: Get Composer Cache Directory | ||
| # id: composer-cache | ||
| # working-directory: ./main | ||
| # run: echo "composer_cache_dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT | ||
|
|
||
| # - name: Install Composer Cache | ||
| # uses: actions/cache@v3 | ||
| # with: | ||
| # path: ${{ steps.composer-cache.outputs.composer_cache_dir }} | ||
| # key: ${{ runner.os }}-composer-${{ hashFiles('**/main/composer.lock') }} | ||
| # restore-keys: | | ||
| # ${{ runner.os }}-composer- | ||
| # - name: Install Composer Dependencies | ||
| # working-directory: ./main | ||
| # run: composer install | ||
|
|
||
| # - name: Checkout Nx Repo | ||
| # uses: actions/checkout@v3 | ||
| # with: | ||
| # repository: adamzero1/nx-for-php | ||
| # ref: docker-wrapper | ||
| # path: nx | ||
|
|
||
| # - name: Install / setup Nx | ||
| # working-directory: ./main | ||
| # run: | | ||
| # npm install -g nx@15.4.1 | ||
| # NXDIR="../nx" | ||
| # cp -r ${NXDIR}/nx ./ | ||
| # cp ${NXDIR}/nx.json ./ | ||
| # cp ${NXDIR}/package.json ./ | ||
| # cp ${NXDIR}/package-lock.json ./ | ||
| # npm ci | ||
| # npm run generate-workspace | ||
| # - name: Print Affected | ||
| # working-directory: ./main | ||
| # run: | | ||
| # AFFECTED_OUTPUT=/tmp/affect.json | ||
| # nx print-affected --head=HEAD --base=remotes/origin/${{ github.event.pull_request.base.ref }} > ${AFFECTED_OUTPUT} | ||
| # echo "Affected Projects: $(jq .projects ${AFFECTED_OUTPUT})" | ||
|
|
||
| # # Warden / Den stuff | ||
| # - name: Checkout Den Repo | ||
| # uses: actions/checkout@v3 | ||
| # with: | ||
| # repository: swiftotter/den | ||
| # path: den | ||
|
|
||
| # - name: Init / Configure Den | ||
| # working-directory: ./main | ||
| # run: | | ||
| # DEN=/home/runner/work/magento2/magento2/den/bin/den | ||
| # ${DEN} env-init magento2 magento2 | ||
| # sed -i 's/WARDEN_DB=.*/WARDEN_DB=0/g' .env | ||
| # sed -i 's/WARDEN_TEST_DB=.*/WARDEN_TEST_DB=0/g' .env | ||
| # sed -i 's/WARDEN_ELASTICSEARCH=.*/WARDEN_ELASTICSEARCH=0/g' .env | ||
| # sed -i 's/WARDEN_OPENSEARCH=.*/WARDEN_OPENSEARCH=0/g' .env | ||
| # sed -i 's/WARDEN_ELASTICHQ=.*/WARDEN_ELASTICHQ=0/g' .env | ||
| # sed -i 's/WARDEN_VARNISH=.*/WARDEN_VARNISH=0/g' .env | ||
| # sed -i 's/WARDEN_RABBITMQ=.*/WARDEN_RABBITMQ=0/g' .env | ||
| # sed -i 's/WARDEN_REDIS=.*/WARDEN_REDIS=0/g' .env | ||
| # sed -i 's/PHP_VERSION=.*/PHP_VERSION=${{ matrix.php_version }}/g' .env | ||
| # ${DEN} env up | ||
| # echo ${{secrets.DEPLOY_PASSWORD}} | sudo -S chmod -R a+rw . | ||
| # # # Unit test command test | ||
| # # - name: Run PHPUnit | ||
| # # working-directory: ./main | ||
| # # run: | | ||
| # # DEN=/home/runner/work/magento2/magento2/den/bin/den | ||
| # # ${DEN} env exec -T php-fpm ./vendor/bin/phpunit --help | ||
| # # ${DEN} env exec -T php-fpm whoami | ||
| # # ${DEN} env exec -T php-fpm ls -lath | ||
|
|
||
| # - name: Configure PHPUnit | ||
| # working-directory: ./main | ||
| # run: | | ||
| # cp dev/tests/unit/phpunit.xml.dist dev/tests/unit/phpunit.xml | ||
| # sed -i '/<extensions>/,/<\/extensions>/d' dev/tests/unit/phpunit.xml | ||
|
|
||
| # - name: Run PHPUnit Nx | ||
| # working-directory: ./main | ||
| # run: | | ||
| # export DEN=/home/runner/work/magento2/magento2/den/bin/den | ||
| # nx affected --target=test:unit --head=HEAD --base=remotes/origin/${{ github.event.pull_request.base.ref }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "services": { | ||
| "php": [ | ||
| 8.1, | ||
| 8.2 | ||
| ] | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding right to left mark's, which PHPs
\NumberFormatteris automatically adding in response.(
[U+200F])Given the involved files haven't been modified in a long time:
I can only guess this is PHP version thing or, has always been here?
magento@91816f7
Even though the comment is incorrect, this commit must of been the start. (n.b reverting this doesn't fix the issue)