Use size hint for HashMap in multiGet. Similar to facebook#1344

adamretter · Sep 29, 2016 · c1b5f05 · c1b5f05
1 parent 87dfc1d
commit c1b5f05
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/java/src/main/java/org/rocksdb/RocksDB.java b/java/src/main/java/org/rocksdb/RocksDB.java
@@ -824,7 +824,8 @@ public Map<byte[], byte[]> multiGet(final List<byte[]> keys)
     final byte[][] values = multiGet(nativeHandle_, keysArray, keyOffsets,
         keyLengths);
 
-    final Map<byte[], byte[]> keyValueMap = new HashMap<>();
+    final Map<byte[], byte[]> keyValueMap =
+        new HashMap<>(computeCapacityHint(values.length));
     for(int i = 0; i < values.length; i++) {
       if(values[i] == null) {
         continue;
@@ -836,6 +837,12 @@ public Map<byte[], byte[]> multiGet(final List<byte[]> keys)
     return keyValueMap;
   }
 
+  private static int computeCapacityHint(final int estimatedNumberOfItems) {
+    // Default load factor for HashMap is 0.75, so N * 1.5 will be at the load
+    // limit. We add +1 for a buffer.
+    return (int)Math.ceil(estimatedNumberOfItems * 1.5 + 1.0);
+  }
+
   /**
    * Returns a map of keys for which values were found in DB.
    * <p>
@@ -880,7 +887,8 @@ public Map<byte[], byte[]> multiGet(
     final byte[][] values = multiGet(nativeHandle_, keysArray, keyOffsets,
         keyLengths, cfHandles);
 
-    final Map<byte[], byte[]> keyValueMap = new HashMap<>();
+    final Map<byte[], byte[]> keyValueMap =
+        new HashMap<>(computeCapacityHint(values.length));
     for(int i = 0; i < values.length; i++) {
       if (values[i] == null) {
         continue;
@@ -915,7 +923,8 @@ public Map<byte[], byte[]> multiGet(final ReadOptions opt,
     final byte[][] values = multiGet(nativeHandle_, opt.nativeHandle_,
         keysArray, keyOffsets, keyLengths);
 
-    final Map<byte[], byte[]> keyValueMap = new HashMap<>();
+    final Map<byte[], byte[]> keyValueMap =
+        new HashMap<>(computeCapacityHint(values.length));
     for(int i = 0; i < values.length; i++) {
       if(values[i] == null) {
         continue;
@@ -971,7 +980,8 @@ public Map<byte[], byte[]> multiGet(final ReadOptions opt,
     final byte[][] values = multiGet(nativeHandle_, opt.nativeHandle_,
         keysArray, keyOffsets, keyLengths, cfHandles);
 
-    final Map<byte[], byte[]> keyValueMap = new HashMap<>();
+    final Map<byte[], byte[]> keyValueMap
+        = new HashMap<>(computeCapacityHint(values.length));
     for(int i = 0; i < values.length; i++) {
       if(values[i] == null) {
         continue;