SERVER-19928 Find command should reject requests to read special comm…

…and namespaces
adamchel · Aug 14, 2015 · 9860212 · 9860212
1 parent a93377f
commit 9860212
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/jstests/noPassthroughWithMongod/find_cmd.js b/jstests/noPassthroughWithMongod/find_cmd.js
@@ -47,3 +47,7 @@ assert.commandFailed(coll.runCommand("find", {foo: "bar"}));
 
 // Filter doesn't parse.
 assert.commandFailed(coll.runCommand("find", {projection: {_id: 0}, filter: {$foo: "bar"}}));
+
+// Special command namespace.
+assert.commandFailed(coll.getDB().runCommand({find: "$cmd"}));
+assert.commandFailed(coll.getDB().runCommand({find: "$cmd.sys.inprog"}));
diff --git a/src/mongo/db/commands/find_cmd.cpp b/src/mongo/db/commands/find_cmd.cpp
@@ -181,7 +181,7 @@ class FindCmd : public Command {
              BSONObjBuilder& result) override {
         const std::string fullns = parseNs(dbname, cmdObj);
         const NamespaceString nss(fullns);
-        if (!nss.isValid()) {
+        if (!nss.isValid() || nss.isCommand() || nss.isSpecialCommand()) {
             return appendCommandStatus(result,
                                        {ErrorCodes::InvalidNamespace,
                                         str::stream() << "Invalid collection name: " << nss.ns()});