Extend LOG003 disallowed extra keys to include message
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @adamchainz, this is a fairly minimal, but impactful change. No pressure, I'll understand if you cannot get to it now. I just want to have an estimate. |
|
Hi @adamchainz, it's been a while. I'd really appreciate this merged, it's important to prevent these types of bugs for us. |
|
Please don’t write “ping” messages, I find it really annoying. |
extra keys to include message
This was referenced Jan 24, 2024
vartec
pushed a commit
to getsentry/sentry
that referenced
this pull request
Jan 25, 2024
Bumping flake8-logging to 1.5.0 to include fix for ```python KeyError "Attempt to overwrite 'message' in LogRecord" ``` Changelog: https://github.com/adamchainz/flake8-logging/blob/main/CHANGELOG.rst#150-2024-01-23 Fix: adamchainz/flake8-logging#77
snigdhas
pushed a commit
to getsentry/sentry
that referenced
this pull request
Jan 26, 2024
Bumping flake8-logging to 1.5.0 to include fix for ```python KeyError "Attempt to overwrite 'message' in LogRecord" ``` Changelog: https://github.com/adamchainz/flake8-logging/blob/main/CHANGELOG.rst#150-2024-01-23 Fix: adamchainz/flake8-logging#77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogRecordspecifically disallows twoFormatter's params"message"and"asctime"inextra:https://github.com/python/cpython/blob/d07483292b115a5a0e9b9b09f3ec1000ce879986/Lib/logging/__init__.py#L1621-L1623
This PR adds missing
"message"missing inLOG003check.This will prevent
Also added parametrized tests which validate all the keys that should be rejected by LOG003.