Drop Python 3.8 support (#600)

Now EOL: https://discuss.python.org/t/python-3-8-is-now-officially-eol/66983 .
adamchainz · Oct 27, 2024 · bd8b055 · bd8b055
1 parent cfba30c
commit bd8b055
Show file tree

Hide file tree

Showing 9 changed files with 7 additions and 69 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -20,7 +20,6 @@ jobs:
     strategy:
       matrix:
         python-version:
-        - 3.8
         - 3.9
         - '3.10'
         - '3.11'

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -34,7 +34,7 @@ repos:
   rev: v3.17.0
   hooks:
   - id: pyupgrade
-    args: [--py38-plus]
+    args: [--py39-plus]
 - repo: https://github.com/psf/black-pre-commit-mirror
   rev: 24.8.0
   hooks:

diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -2,6 +2,8 @@
 Changelog
 =========
 
+* Drop Python 3.8 support.
+
 * Support Python 3.13.
 
 3.15.0 (2024-06-29)

diff --git a/README.rst b/README.rst
@@ -27,7 +27,7 @@ Check out my book `Boost Your Django DX <https://adamchainz.gumroad.com/l/byddx>
 Requirements
 ============
 
-Python 3.8 to 3.13 supported.
+Python 3.9 to 3.13 supported.
 
 Installation
 ============

diff --git a/pyproject.toml b/pyproject.toml
@@ -19,15 +19,14 @@ keywords = [
 authors = [
   { name = "Adam Johnson", email = "me@adamj.eu" },
 ]
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 classifiers = [
   "Development Status :: 5 - Production/Stable",
   "Framework :: Flake8",
   "Intended Audience :: Developers",
   "License :: OSI Approved :: MIT License",
   "Natural Language :: English",
   "Programming Language :: Python :: 3 :: Only",
-  "Programming Language :: Python :: 3.8",
   "Programming Language :: Python :: 3.9",
   "Programming Language :: Python :: 3.10",
   "Programming Language :: Python :: 3.11",

diff --git a/src/flake8_comprehensions/__init__.py b/src/flake8_comprehensions/__init__.py
@@ -1,9 +1,9 @@
 from __future__ import annotations
 
 import ast
+from collections.abc import Generator
 from importlib.metadata import version
 from typing import Any
-from typing import Generator
 
 
 class ComprehensionChecker:

diff --git a/tests/requirements/compile.py b/tests/requirements/compile.py
@@ -19,7 +19,6 @@
         *sys.argv[1:],
     ]
     run = partial(subprocess.run, check=True)
-    run([*common_args, "--python", "3.8", "--output-file", "py38.txt"])
     run([*common_args, "--python", "3.9", "--output-file", "py39.txt"])
     run([*common_args, "--python", "3.10", "--output-file", "py310.txt"])
     run([*common_args, "--python", "3.11", "--output-file", "py311.txt"])

diff --git a/tests/requirements/py38.txt b/tests/requirements/py38.txt
diff --git a/tox.ini b/tox.ini
@@ -2,7 +2,7 @@
 requires =
     tox>=4.2
 env_list =
-    py{313, 312, 311, 310, 39, 38}
+    py{313, 312, 311, 310, 39}
 
 [testenv]
 package = wheel
-Original file line number
+Diff line change
@@ Expand Up / @@ -20,7 +20,6 @@ jobs: @@
         strategy:
           matrix:
             python-version:
-            - 3.8
             - 3.9
             - '3.10'
             - '3.11'
@@ Expand Down @@