Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Private Network Check #745

Closed
wants to merge 2 commits into from

Conversation

issackelly
Copy link

Google is starting to ship checks for Private Networks[1]. This is causing me to make some adjustments to my site and I figured I'd start down the path of a PR.

[1] https://developer.chrome.com/blog/private-network-access-preflight/

@adamchainz
Copy link
Owner

Thanks for this. First time I've heard of this feature!

After skimming the spec, it looks like one should only respond with Access-Control-Allow-Private-Network if Access-Control-Request-Private-Network is present in the request. Could you make that change? Also please add a release note.

Copy link
Owner

@adamchainz adamchainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

@issackelly
Copy link
Author

of course. thanks for the quick response. I will try to make this change shortly.

@flaper87
Copy link

@issackelly any chance you have some time to address @adamchainz feedback? 🙏

@untidy-hair
Copy link

Hi, can this be merged soon? Thanks everyone.

@adamchainz
Copy link
Owner

Superceded by #833, which has been merged with co-authored-by for you @issackelly . Thanks for your work.

@adamchainz adamchainz closed this May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants