Create Light and Italic font faces #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] It is easier to work with the scripts and git, if all normally created intermediate files are ignored. It allows to do a 'git clean -f' for example. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] The version parameter is not optional, so it should not be noted as optional. I'm not sure if it ever was optional, maybe a leftover from a different, previous approach. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
The script is hardcoded to provide a 'Regular' font face. Now that we
want to generate other faces we need to be more flexible.
[how]
Add a parameter that is used in the appropriate places.
Sometimes the style has no additional name ("Italic" face). To allow
that we need to be careful with added blancs in the name strings.
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] The demand for correctly working bold and italic fonts can not be satisfied with our simple approach. We need a whole lot more fonts! [how] Use the static Cascadia font versions and do the patching on all relevant fonts. Use a helper script to invoke the actual patching to hide all the parameters that stay the same for all the fonts. Group the created fonts by interest (small (powerline), complete, book) and release as zip packages. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] When we work with the static font files we do not need to prepare (fix for working with them in fontforge) them anymore. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] The version in the font files reflects not the version name we want to have. In fact it is just the git hash of the topmost commit and not the git tag. [how] When switching to actions/checkout@v2 we only fetch the latest commit into the git workflow (for performance reasons is this the default). But that lacks all the tags, that we use to communicate the font version. Now we resort to full depth cloning of the Delugia repository, which is tiny anyway. [note] Action had been updated from @1 to @2 with commit 22d4cae Combine workflows (adam7#57) Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
We have 'normal' and 'bold' in one font family, but the 'italic' is in a
separate family. Some applications can group the weights/styles of one
font family in a way that allows to select 'bold' and/or 'italic' in the
application easily - without choosing a different font.
This seems to be broken if the italics is in a separate font family.
We have these families -> styles:
Deligia{}
-> Regular, Bold
Delugia{}Light
-> "" (Regular)
Delugia{}Italic
-> Italic, Bold-Italic
Delugia{}ItalicLight
-> Italic
[how]
Restructure the family names -> styles as such:
Deligia{}
-> Regular, Bold, Italic, Bold-Italic
Delugia{}Light
-> "" (Regular), Bold
[note]
With {} being our 5 styles:
PL, MonoPL, Complete, MonoComplete, Book
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] The full name fields should contain the full name (obviously) including the subfamily. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] If one specific font is to be identified we need an ID that changes with new revisions. [how] Add the version to the ID. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] These Families are created: - Delugia PL - Delugia Mono PL - Delugia Complete - Delugia Mono Complete - Delugia Book At the moment we put both non-mono and mono families into one archive like so: 1. Delugia PL and Delugia Mono PL 2. Delugia Complete and Delugia Mono Complete 3. Delugia Book For some users it might make more sense to bundle the non-mono and mono fonts. The majority probably needs just one family. It might be unclear for users that these are 5 independent font sets. [how] Just stuff the files into more archives: 1. Delugia PL 2. Delugia Complete 3. Delugia Book Ligarture-less variants: 4. Delugia Mono PL 5. Delugia Mono Complete Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
Hmm, the last 4 commits do not have any commit message. |
|
You can see the new README (with 2 example images) rendered here https://github.com/Finii/delugia-code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some issues (#44, #45, #58) that can most likely be solved if we create the fonts not from the dynamic Cascadia Code font but select the adequate static font that is also provided by Microsoft.
In this way we can also include the italic and light font faces.
With this PR we have now 5 archives:
that contains 6 font files each:
More information is in the discussion of #58.
Also included two font images in the README file.