Fix width of glyph 'grave' #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] On Applications that can work with ligatures and non-monospaced fonts the grave accent is handled as if it has zero width. The next character is drawn directly on top of the accent, resulting in an accented letter (where there is none) or only one accent if there are many consecutive ones. [how] It is not clear why the character fails to have any width, but if the glyph type is set to handle this glyph as ordinary character the handling is ok. Somehow the autodetection of glyph type is broken? Fixes: 5 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
@Finii Thanks for this and the other fixes 🙇♂️ |
Closed
This was referenced Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
On Applications that can work with ligatures and non-monospaced fonts
the grave accent is handled as if it has zero width. The next character
is drawn directly on top of the accent, resulting in an accented letter
(where there is none) or only one accent if there are many consecutive
ones.
[how]
It is not clear why the character fails to have any width, but if the
glyph type is set to handle this glyph as ordinary character the
handling is ok. Somehow the autodetection of glyph type is broken?
Fixes: #5
Signed-off-by: Fini Jastrow ulf.fini.jastrow@desy.de