gives preferred status to first mapper errors - refs swagger-api#3911

adagios · Apr 20, 2021 · 592cfa4 · 592cfa4
1 parent 123577e
commit 592cfa4
Showing 1 changed file with 16 additions and 5 deletions.
diff --git a/modules/swagger-maven-plugin/src/main/java/io/swagger/v3/plugin/maven/SwaggerMojo.java b/modules/swagger-maven-plugin/src/main/java/io/swagger/v3/plugin/maven/SwaggerMojo.java
@@ -201,24 +201,35 @@ private <T> Optional<T> readStructuredDataFromFile(String filePath, Class<T> out
             List<BiFunction<String, Class<T>, T>> mappers = getSortedMappers(pathObj);
 
             T instance = null;
-            Throwable caughtEx = null;
+            List<Throwable> caughtExs = new ArrayList<>();
 
             // iterate through mappers and see if one is able to parse
             for (BiFunction<String, Class<T>, T> mapper : mappers) {
                 try {
                     instance = mapper.apply(fileContent, outputClass);
                     break;
                 } catch (Exception e) {
-                    caughtEx = e;
+                    caughtExs.add(e);
                 }
             }
 
             // if no mapper could read the content correctly, finish with error
             if (instance == null) {
-                if (caughtEx == null) {
-                    caughtEx = new IllegalStateException("undefined state");
+                if (caughtExs.isEmpty()) {
+                    caughtExs.add(new IllegalStateException("undefined state"));
                 }
-                getLog().error(format("Could not read file '%s' for config %s", pathObj.toString(), configName), caughtEx);
+
+
+                // we give more importance to the first exception, it was produced by the preferred mapper
+                Throwable caughtEx = caughtExs.get(0);
+                getLog().error(format("Could not read file '%s' for config %s", pathObj, configName), caughtEx);
+
+                if(caughtExs.size() > 1){
+                    for (Throwable ex : caughtExs.subList(1, caughtExs.size())) {
+                        getLog().warn(format("Also could not read file '%s' for config %s with alternate mapper", pathObj, configName), ex);
+                    }
+                }
+
                 throw new IllegalStateException(caughtEx.getMessage(), caughtEx);
             }