make SPI RX/TX dma startup be atomic #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Jun 17, 2022
This was referenced Jun 17, 2022
|
Many thanks for this fix. Matrixportal now finally runs rock solid! |
flavio-fernandes
added a commit
to flavio-fernandes/kitchen_clock
that referenced
this pull request
Jul 30, 2022
This update includes important fixes to Matrix Portal lockup: samd: RGBMatrix causing DMA hangs adafruit/circuitpython#6489 make SPI RX/TX dma startup be atomic adafruit/samd-peripherals#42 Signed-off-by: Flavio Fernandes <flavio@flaviof.com>
flavio-fernandes
added a commit
to flavio-fernandes/kitchen_clock
that referenced
this pull request
Jul 30, 2022
Update README to include Adafruit's Show-and-Tell recording. This update includes important fixes to Matrix Portal lockup: samd: RGBMatrix causing DMA hangs adafruit/circuitpython#6489 make SPI RX/TX dma startup be atomic adafruit/samd-peripherals#42 Signed-off-by: Flavio Fernandes <flavio@flaviof.com>
flavio-fernandes
added a commit
to flavio-fernandes/kitchen_clock
that referenced
this pull request
Jul 30, 2022
Update README to include Adafruit's Show-and-Tell recording. This update includes important fixes to Matrix Portal lockup: samd: RGBMatrix causing DMA hangs adafruit/circuitpython#6489 make SPI RX/TX dma startup be atomic adafruit/samd-peripherals#42 Signed-off-by: Flavio Fernandes <flavio@flaviof.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix adafruit/circuitpython#6489. When ProtoMatter is in use, it runs an ISR at priority 0 about 1/3 of the time. After an indefinite period of time (could be minutes or an hour), the TX part of SPI would hang, waiting for completion. I believe this was due to ProtoMatter sneaking in between the startup of the RX DMA and the TX DMA. Making the RX/TX startup be atomic seems to have fixed this problem, based on empirical tests running for several hours.
After this is merged, I will PR an update the submodule in circuitpython.