CIRCUITPY_USB_DEVICE_INSTANCE should default to 0 on most Espressif boards

[dhalbert]

• Fixes #9841 has broken ESP32-S2 and ESP32-S3 USB #9888.

#9841 set CIRCUITPY_USB_DEVICE_INSTANCE to 1 as the default for all Espressif boards. However, on nearly all boards, it should be 0, not 1. The ESP32-P4 dev board uses 1 to use the second interface by default.

@tannewt should be it 1 for all ESP32-P4 boards, or does it depend on the board wiring?

Tested that it's fixed on a Feather ESP32-S3 4/2 board.

[RetiredWizard]

I quickly loaded this artifact onto my MatrixPortal S3 and it does bring back the CIRCUITPY drive that didn't appear using the "absolute newest" build, however I ran into another apparently unrelated safemode issue. I'll open a new issue on that shortly.

[tannewt]

P4 boards will have the choice to use full speed or high speed USB. Instance 1 is the high speed (480) usb. I was thinking full speed would be usb host.

[tannewt]

Thank you for the fix!

[dbiersach]

On my Adafruit Metro ESP32-S3 with 16 MB Flash 8 MB PSRAM, all versions after adafruit-circuitpython-adafruit_metro_esp32s3-en_US-20241206-main-PR9873-c41d452.uf2 (#9873) fail to restart CIRCUITPY upon flashing the UF2 and performing a hard reset of the board. I know there was a discussion on Issue #9888, and the thought was that PR9889 had fixed the issue but not for the Metro ESP32-S3 board. Upon flashing the UF2, CIRCUITPY does reappear, but if you reset the board, the volume fails to mount. If you go back to CircuitPython 9.2.1, it will work great. Try to upgrade to CP 9.2.2, but you get this error where the board falls back into JTAG mode. I suspect the underlying bug is not yet fixed.