RP2350: need cache flush in microcontroller.nvm #9783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
reviewed
Nov 2, 2024
jepler
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lower-level flash-write code in
supervisor/internal_flash.cdoes cache flushing when PSRAM is in use. Some of that code is duplicated inmicrocontroller.nvm, but it didn't have the cache flushing.nvmcode, and use it ininternal_flash.c.Also see:
https://forums.raspberrypi.com/viewtopic.php?t=378249
There may later be pico-sdk support for some of this:
raspberrypi/pico-sdk#1983
raspberrypi/pico-sdk#2005