Add global GCC version check #9779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can set some of them lower than 13 if necessary on a per-port basis. At least esp32 and arm ports all use 13 from what I could see.
dhalbert
approved these changes
Nov 1, 2024
dhalbert
approved these changes
Nov 1, 2024
|
I can change the message because it's not actually the case that e.g., arm gcc 12 is "known to miscompile" the raspberrypi port, but this is the general idea of stopping folks from accidentally building with a gcc version different than what we use during CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can set some of them lower than 13 if necessary on a per-port basis. At least esp32 and arm ports all use 13 from what I could see.
I recently lost some time because CircuitPython for rp2040 built with gcc 10 just didn't work (wouldn't boot). It seems preferable to stop the build if it's an older version of GCC than the one we use in CI, unless we specifically test some older versions.