Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default values for wifi.Radio.start_dhcp_client() #9751

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

dhalbert
Copy link
Collaborator

Fixes #9750. Thanks @bablokb for the diagnosis!

@dhalbert dhalbert requested review from tannewt and jepler October 23, 2024 13:27
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit c606994 into adafruit:main Oct 23, 2024
226 checks passed
@jepler
Copy link
Member

jepler commented Oct 23, 2024

belated thanks from me as well!

@dhalbert dhalbert deleted the dhcp-arg-defaults branch October 23, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wifi.radio.start_dhcp() fails with NotImplementedError
3 participants