Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://forums.adafruit.com/viewtopic.php?t=213955 by blakebr notes that
os.uname().sysname
and.nodename
sayrp2040
even forrp2350
boards. Fix this by usingMICROPY_HW_MCU_NAME
instead. Note that it would berp2350a
andrp2350b
.Note that on some ports, the name is more generic, such as
samd21
andsamd51
foratmel-samd
. Butespressif
andbroadcom
useMICROPY_HW_MCU_NAME
. In the long run, maybe that is better, since it's more informative, instead of using a generic name. This could be a 10.0 change.