Correct ble_serial_connected()
when BLE workflow was never started
#9679
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ble_serial_connected()
was checking_tx_packet_buffer.conn_handle
as an indicator of whether BLE was connected. But that value was not initialized when BLE hadn't started up at all, and soble_serial_connected()
was returningtrue
incorrectly in that case. The check should have also included a check for deinited. I added that and refactored it into a common-hal routine.I asked the issue authors to test. It fixed the problem for at least one of them: #9626 (comment)