Use new ESP-IDF I2C driver #9671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make busio.I2C use finalizers for reset instead of bulk reset. This makes it easier to track and free the memory that the IDF allocates internally for its "handle".
- Starts with @tannewt's changes. - Make sure proper component is being compiled. - Added `I2C.probe()` as a visible new method. This was a hidden common-hal method, but the C version of adafruit_bus_device could not use it because it needs to call probe via a Python method call. So make it visible. It's useful, and `I2C.scan()` could be phased out, since now `.scan()` can be implemented in Python with `.probe()`. - set clock-stretching timeout on espressif to a minimum of 1 second. In all impls of busio.I2C()`, the timeout is ignored and is set to a fixed 1 second. @tannewt's new code was using the passed-in value, which was often too short. To do: - switch esp-camera to new-driver version. We have to use the same I2C driver everywhere. - Check about I2CTarget.
|
A few builds overflowed. I turned off some unused pins. I also did |
bff82f4 to
3ed7698
Compare
jepler
requested changes
Sep 30, 2024
|
thanks for working on this! |
This was referenced Oct 9, 2024
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use new ESP-IDF I2C driver. @tannewt did most of this work in tannewt@8a4ad54 (https://github.com/tannewt/circuitpython/tree/idf5.2_i2c). I started with that, fixed a few things, and fixed some issues with the esp32-camera library, which recently had a PR to use the new driver.
I retested the problems reported in #9535 and #9561 amd they seem to be fixed.
I added an
I2C.probe(address)method. There has to be a method in the class dictionary so that the nativeadafruit_bus_device.I2CDevicecan do a probe for a specific address on anything that acts likeI2C. Previously it was not actually using the common-halprobe()operation, but instead was "manually" doing a zero-length write. Now it uses whateverprobe()is provided by bitbangio.I2C or busio.I2C.In the long run the presence of
.probe()means that uses of.scan()could be replaced with a tiny amount of Python code:[address for address in range(128) if i2c.probe(address)]. But this incompatible change would come at a major version bump.