Add a delay to KeyMatrix scan. #9665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives the matrix columns time to discharge and settle down to their resting state.
|
There were spaces on the blank lines you added. pre-commit doesn't like that. I edited the file to remove them. |
|
Oops! Thanks for fixing it up. I was just firing up my ubuntu VM again to run the pre-commit script. I guess my Notepad++ settings disagree with the linter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives the matrix columns more time to discharge and settle down to their resting state. PR #5031 improved matters but didn't seem to wait long enough for keypads/keyboards with particularly long traces.
See issue #7621 for discussion.