Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LILYGO TEMBED ESP32-S3: fix init sequence in board.c #9650

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

bytiful
Copy link

@bytiful bytiful commented Sep 22, 2024

For lilygo_tembed_esp32s3 in display init sequence added command INVON and changed MADCTL from BRG to RGB

For lilygo_tembed_esp32s3 in display init sequence added command INVON and changed MADCTL from BRG to RGB
@dhalbert
Copy link
Collaborator

@titimoby these changes are in conflict with what you submitted in your pull request #7658. I'm assuming you tested. Has the board changed? @bytiful are you using a genuine LILYGO board or a clone?

@bytiful
Copy link
Author

bytiful commented Sep 23, 2024

I'm assuming you tested.

Yes, I compiled the changes and uploaded them to my board.

LILYGO_T-EMBED_ESP32S3

I do not know if I have a clone or a real board, but it looks like the image "Pin Diagram"on the official website

@jepler
Copy link
Member

jepler commented Nov 4, 2024

I ran pre-commit on the file changed in this commit, so that hopefully the CI completes successfully. Absent input from @titimoby we may want to just go ahead and merge this as a bugfix.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging and we'll see whether there are complaints.

@dhalbert dhalbert merged commit 071927e into adafruit:main Nov 19, 2024
14 of 15 checks passed
@dhalbert dhalbert changed the title fix init sequence in board.c LILYGO TEMBED ESP32-S3: fix init sequence in board.c Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants