Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set UF2 boot value without SD #9618

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Sep 12, 2024

Fallback to setting GPREGRET without SD if it isn't active. This fixes resetting into UF2 when BLE isn't active. Fixes #9423

Fallback to setting GPREGRET without SD if it isn't active. This
fixes resetting into UF2 when BLE isn't active. Fixes micropython#9423
@tannewt tannewt added this to the 9.1.x milestone Sep 12, 2024
@tannewt tannewt requested a review from dhalbert September 12, 2024 21:49
@tannewt tannewt linked an issue Sep 12, 2024 that may be closed by this pull request
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems sensible, good to merge if you tested it too :)

@tannewt tannewt removed the request for review from dhalbert September 12, 2024 21:52
@tannewt
Copy link
Member Author

tannewt commented Sep 12, 2024

Yup! Tested on Feather nRF52840.

@tannewt tannewt merged commit 2581deb into adafruit:9.1.x Sep 12, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nordic: RunMode.UF2 stopped working in 9.1.0-beta.4 and later
2 participants