Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RP2350 unique module build settings #9617

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Sep 12, 2024

This enables picodvi by default on RP2350 boards and fixes #9615

This enables picodvi by default on RP2350 boards and fixes micropython#9615
@tannewt tannewt added this to the 9.2.0 milestone Sep 12, 2024
@tannewt tannewt requested a review from jepler September 12, 2024 21:03
It doesn't work due to the E9 errata on A2 hardware.

Fixes micropython#9541
@tannewt tannewt linked an issue Sep 12, 2024 that may be closed by this pull request
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. floppyio should work on rp2350 and this build should test that.

@tannewt
Copy link
Member Author

tannewt commented Sep 12, 2024

Looks good. floppyio should work on rp2350 and this build should test that.

Yup, some had them on. I think it was an artifact from early builds.

@tannewt tannewt merged commit fe7e872 into adafruit:main Sep 12, 2024
134 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default picodvi to on for all RP2350 boards RP2350: hardware issue: stuck inputs
2 participants