Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include VIDI X HW revision in the MICROPY_HW_BOARD_NAME #9613

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

lovrojakic
Copy link

@lovrojakic lovrojakic commented Sep 10, 2024

Hi!

In this pull request, I would like to specify that this firmware is intended for the VIDI X V1.1 revision. Since new revisions of the board are expected in the future, I updated the MICROPY_HW_BOARD_NAME accordingly.

Thank you!

@lovrojakic lovrojakic changed the title Include VIDI X revision in the directory name and MICROPY_HW_BOARD_NAME Include VIDI X HW revision in the MICROPY_HW_BOARD_NAME Sep 11, 2024
@dhalbert
Copy link
Collaborator

The directory board name is still vidi_x. Do you want to include the revision in there too? Are you expecting incompatible changes as the board is revised?

@lovrojakic
Copy link
Author

Hi, I was instructed to use vidi_x for the circuitpython-org PR and that's why I reverted the name change here. If some breaking changes occur in the future, then the new board will have a HW revision in the name from the beginning, and this one will stay like this. Do you agree or have any other suggestions?

This is the PR I mentioned:
adafruit/circuitpython-org#1471 (review)

@dhalbert
Copy link
Collaborator

OK, we can leave the directory name alone for now. It's not critical.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert merged commit 64505f3 into adafruit:main Sep 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants