Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend EVE hardware opcodes for future-compatibility #9604

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

jamesbowman
Copy link

Extend the bitfields of these instructions: BitmapHandle, ClearTag, Tag, BitmapSource, PaletteSource
Add instructions: BitmapSourceH PaletteSourceH

All the new bits and opcodes are ignored by earlier hardware, so this change is backwards-compatible.

Passes tests on all EVE hardware.

Extend the bitfields of these instructions: BitmapHandle, ClearTag, Tag, BitmapSource, PaletteSource
Add instructions: BitmapSourceH PaletteSourceH

All the new bits and opcodes are ignored by earlier hardware, so this change is backwards-compatible.

Passes tests on all EVE hardware.
tannewt
tannewt previously approved these changes Sep 6, 2024
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me! Thanks!

@dhalbert
Copy link
Collaborator

dhalbert commented Sep 9, 2024

@tannewt I had to make room on Feather M4 and Metro M4. I turned off aesio, but should we turn off something else instead? @jamesbowman Are these boards used with eve hardware?

@dhalbert
Copy link
Collaborator

dhalbert commented Sep 9, 2024

@tannewt @jamesbowman I was able to remove microcontroller.pin.<somepin> for a few pins that were not connected on Feather M4 and Metro M4, and so left aesio alone. This is good for a short while. Probably eventually we'll need to turn off something larger.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this builds for all boards we can merge it.

@dhalbert dhalbert merged commit b3283d2 into adafruit:main Sep 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants