Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Barduino Board #9603

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Conversation

JosepMartiElias
Copy link

Adding Barduino PID's.

Barduino is a development board created by Fablab Barcelona as a tool for it's educational programs.

ESP32-S3 (ESP32-S3-WROOM-1)

It needs a custom PID to have the opportunity to show it officialy in the CircuitPython website and to create an Arduino core for it.

It's done under Fablab Barcelona, part of IAAC.

This is (will be because it's a WIP) the documentation for the board https://fablabbcn-projects.gitlab.io/electronics/barduino-docs/
and this is Fablab Barcelona https://fablabbcn.org/
and this IAAC https://iaac.net/

Thank you!

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi - just some pins.c questions and requests.

ports/espressif/boards/barduino/pins.c Show resolved Hide resolved
ports/espressif/boards/barduino/pins.c Outdated Show resolved Hide resolved
ports/espressif/boards/barduino/pins.c Outdated Show resolved Hide resolved
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more suggestion: PT -> LIGHT

{ MP_ROM_QSTR(MP_QSTR_IO1), MP_ROM_PTR(&pin_GPIO1) },
{ MP_ROM_QSTR(MP_QSTR_IO2), MP_ROM_PTR(&pin_GPIO2) },

{ MP_ROM_QSTR(MP_QSTR_PT), MP_ROM_PTR(&pin_GPIO3) }, // PT = phototransistor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The standard name on other boards for this is LIGHT, short for "light sensor"

Suggested change
{ MP_ROM_QSTR(MP_QSTR_PT), MP_ROM_PTR(&pin_GPIO3) }, // PT = phototransistor
{ MP_ROM_QSTR(MP_QSTR_LIGHT), MP_ROM_PTR(&pin_GPIO3) }, // PT = phototransistor

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience!

@dhalbert dhalbert merged commit 4e7b0d3 into adafruit:main Sep 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants