Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for new custom board - CircuitArt ESP32S3 zero #9593

Merged
merged 6 commits into from
Sep 4, 2024
Merged

add support for new custom board - CircuitArt ESP32S3 zero #9593

merged 6 commits into from
Sep 4, 2024

Conversation

CircuitART
Copy link

This is a custom board that i developed it using the same footprint as pi zero.
the PID was obtained from Espressif espressif/usb-pids#33
I have already build and tested circuitpython on it, and so far all is good

fixed: add space after the comments operator (//)
added space after the comment operator (//)
removed unsupported frozen lib
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to the Feather S3 that you requested the PID for? It is weird you are reusing it.

ports/espressif/boards/circuitart_zero_s3/mpconfigboard.mk Outdated Show resolved Hide resolved
typo mistake

Co-authored-by: Scott Shawcroft <scott@tannewt.org>
@CircuitART
Copy link
Author

my Feather S3 project was canceled and replaced with the zero version, I opened new pull request in espressif pid requesting changes on the pid name as well

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks!

@tannewt tannewt merged commit 8dc7102 into adafruit:main Sep 4, 2024
15 checks passed
@CircuitART
Copy link
Author

@tannewt just thought to let u know know that Espressif-pid has been changed successfully
espressif/usb-pids#179

@tannewt
Copy link
Member

tannewt commented Sep 5, 2024

Thank you @CircuitART

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants