Add support for ulab.numpy float vectors in Vertex2f() #9589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using numpy greatly increases graphics drawing for complex geometry.
dhalbert
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Could you conditionalize this so the new code is used only #if CIRCUITPY_ULAB is true, and the old way is used otherwise? It's possible to set up complations that way, so that _eve is enabled but ulab is not, and it would be good to support that combination. Thanks.
This allows _eve to build without ulab.
dhalbert
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using numpy greatly increases speed when drawing complex geometry.
