-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds iLabs Challenger boards. #9562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One pre-commit issue. Good otherwise!
ports/raspberrypi/boards/challenger_rp2350_wifi6_ble5/mpconfigboard.mk
Outdated
Show resolved
Hide resolved
If you are editing files through the GitHub web interface, it is sometimes hard to get the last lines correct. Pushing from a local copy will make sure that what you think is in the file is really there. |
Don't worry about the doc build failure -- we know about that and it is unrelated. |
The good news is, your last push did resolve the pre-commit problem during CI. The failure was in building the documentation, which is not due to your PR. It can be ignored. (should be fixed by #9580) The other problem that needs to be fixed is that your latest change also changes the Pico-PIO-USB submodule. Using I made an attempt to fix this but I was not permitted by github to add my change to this PR:
so, you will have to resolve this. The steps I followed were roughly:
once you've done these steps and pushed, you should be able to look at the list of files changed on github and see that Pico-PIO-USB is not listed. I can't recommend strongly enough to use a tool (whether command-line or GUI) that individually selects which files to commit, to avoid irritations like this. |
One other thing maybe worth changing for the challenger_rp2350_wifi6_ble: I would also keep the pin-names in sync. I assume there will be users upgrading from the rp2040_wifi_ble and they will certainly be more happy if they don't need to change their programs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Please also make a PR to https://github.com/raspberrypi/usb-pid to publicly document the PIDs.
This PR adds the following boards: