Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Building CircuitPython guide easier to find #9554

Merged
merged 4 commits into from
Aug 25, 2024

Conversation

samblenny
Copy link

These documentation edits are meant to steer new CircuitPython core developers towards the Building CircuitPython Learn Guide.

This relates to issue #9552 , which describes a couple minor problems I had with navigating the build documentation to set up a build environment for the Espressif port on Linux.

These documentation edits are meant to steer new CircuitPython
core developers towards the Building CircuitPython Learn Guide.
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. One spelling typo only. I'm also interested in Scott's opinion about what should be in these files.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@samblenny samblenny marked this pull request as ready for review August 23, 2024 03:45
@samblenny samblenny requested a review from dhalbert August 23, 2024 21:29
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert merged commit 16b6c88 into adafruit:main Aug 25, 2024
547 checks passed
@samblenny samblenny deleted the espressif-build-docs branch August 25, 2024 23:52
@tannewt
Copy link
Member

tannewt commented Aug 27, 2024

Thanks for this. One spelling typo only. I'm also interested in Scott's opinion about what should be in these files.

Stuff in the repo should be things we want the community to be able to contribute to. The espressif port is mainly maintained by us (Adafruit folks) so we can slim it down and link out if we like. Other ports may have more details here if they were added by other folks.

I'd only use Learn for Adafruit maintained things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants