correct board special pin setup #9553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
485f75d to
4e97bdd
Compare
4e97bdd to
6759007
Compare
|
fantastic, thank you Dan! i tested with the C6 and the pin is high without having to manually set it. also tested with an s3 TFT feather and s3 feather no psram and both of those were still functioning properly |
BlitzCityDIY
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
espressif_board_reset_pin_number()was being used on many boards to set certain pins high or low on startup. However, it was using basicgpiofunctions without ensuring that the IOMUX for pin was set to GPIO. This meant the GPIO settings were not necessarily taking effect. This may have caused issues on other boards we didn't know about besides the Feather C6 from #9551.I added a helper routine to ensure that
gpio_config()was called before setting the pin level.gpio_config()does the IOMUX configuring.A helper routine to set pulls could also be added, but some boards use a disabled pin with a pull, and some use an input pin. So I didn't do this now.
Tested on Feather ESP32-C6, which now turns on
board.NEOPIXEL_I2C_POWERas it should.This PR also includes #9549, to avoid failure in the Windows build job.