Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing improvements #9548

Merged
merged 9 commits into from
Aug 28, 2024
Merged

Typing improvements #9548

merged 9 commits into from
Aug 28, 2024

Conversation

elpekenin
Copy link

No description provided.

@elpekenin elpekenin marked this pull request as ready for review August 22, 2024 22:12
@elpekenin elpekenin changed the title Missed wrong comment about ScanEntry.matches Couple missed fixed for _bleio Aug 22, 2024
@elpekenin elpekenin changed the title Couple missed fixed for _bleio Typing improvements Aug 23, 2024
tannewt
tannewt requested changes Aug 27, 2024
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these corrections! I added a couple questions.

shared-bindings/_bleio/CharacteristicBuffer.c Outdated Show resolved Hide resolved
shared-bindings/synthio/LFO.c Outdated Show resolved Hide resolved
shared-bindings/synthio/Math.c Outdated Show resolved Hide resolved
shared-bindings/usb_video/USBFramebuffer.c Outdated Show resolved Hide resolved
tannewt
tannewt approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit e8515c1 into adafruit:main Aug 28, 2024
434 checks passed
@elpekenin elpekenin deleted the fix/_bleio-stubs branch August 28, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elpekenin @tannewt