Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add four Pimoroni RP2350 boards #9531

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Add four Pimoroni RP2350 boards #9531

merged 4 commits into from
Aug 21, 2024

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Aug 16, 2024

No description provided.

@tannewt tannewt requested a review from dhalbert August 16, 2024 22:39
@tannewt
Copy link
Member Author

tannewt commented Aug 16, 2024

cc: @todbot @ZodiusInfuser @Gadgetoid

dhalbert
dhalbert requested changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi - the files all need new-style headers.

@ZodiusInfuser
Copy link

Thanks for setting these up @tannewt ! I take it you saw the USB PIDs appear in Pi's repo?

I've had a look over and they overall seem good. There are a few things that could be added, so I'll raise separate comments for those.

@ZodiusInfuser
Copy link

Comments all added

@tannewt tannewt requested a review from dhalbert August 19, 2024 21:05
@tannewt
Copy link
Member Author

tannewt commented Aug 19, 2024

All RP2350 headers updated using the script as well as addressed @ZodiusInfuser's comments.

I take it you saw the USB PIDs appear in Pi's repo?

Yup! I used those.

@ZodiusInfuser
Copy link

LGTM!

@tannewt
Copy link
Member Author

tannewt commented Aug 21, 2024

@dhalbert This is ready for a final look.

dhalbert
dhalbert approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and I'm depending on @ZodiusInfuser for the details like VID/PID, etc.

@dhalbert dhalbert merged commit dfc3e99 into adafruit:main Aug 21, 2024
15 checks passed
@tannewt
Copy link
Member Author

tannewt commented Aug 21, 2024

For the record. USB PIDs are publicly documented here: https://github.com/raspberrypi/usb-pid/blob/96bdf45629c09004f2d628b9573d7a901a64eb23/Readme.md?plain=1#L187-L190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZodiusInfuser ZodiusInfuser ZodiusInfuser left review comments

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tannewt @ZodiusInfuser @dhalbert