Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config that works on Seeed Xiao ESP32S3 #9530

Merged
merged 29 commits into from
Sep 3, 2024
Merged

Config that works on Seeed Xiao ESP32S3 #9530

merged 29 commits into from
Sep 3, 2024

Conversation

djairjr
Copy link

@djairjr djairjr commented Aug 16, 2024

For some reason, my old USB_VID and USB_PID values does not compile a correct firmware. This one, make a USB drive available.

@djairjr
Config that works on Seeed Xiao ESP32S3
f3dc89d 
For some reason, my old USB_VID and USB_PID values does not compile a correct firmware. This one, make a USB drive available.
dhalbert
dhalbert requested changes Aug 16, 2024
View reviewed changes
ports/espressif/boards/seeed_xiao_esp32_s3_sense/mpconfigboard.mk Outdated Show resolved Hide resolved
ports/espressif/boards/seeed_xiao_esp32_s3_sense/board.c Outdated Show resolved Hide resolved
ports/espressif/boards/seeed_xiao_esp32_s3_sense/board.c Show resolved Hide resolved
ports/espressif/boards/seeed_xiao_esp32_s3_sense/mpconfigboard.h Outdated Show resolved Hide resolved
ports/espressif/boards/seeed_xiao_esp32_s3_sense/mpconfigboard.h Show resolved Hide resolved
ports/espressif/boards/seeed_xiao_esp32_s3_sense/mpconfigboard.mk Outdated Show resolved Hide resolved
ports/espressif/boards/seeed_xiao_esp32_s3_sense/mpconfigboard.mk Show resolved Hide resolved
ports/espressif/boards/seeed_xiao_esp32_s3_sense/pins.c Show resolved Hide resolved
ports/espressif/boards/seeed_xiao_esp32_s3_sense/sdkconfig Show resolved Hide resolved
djairjr added 15 commits August 17, 2024 12:23
@djairjr
Update pins.c
0d98799 
I added missing pins and made the naming of the camera and microphone pins clearer.
@djairjr
Update pins.c
6e020ea
@djairjr
Update pins.c
1aac66d 
Added tuple with Camera Datalines 
as indicated in Adafruit espcamera tutorial: https://learn.adafruit.com/capturing-camera-images-with-circuitpython
@djairjr
Update pins.c
685e9ad
@djairjr
Update pins.c
3a35664 
White spaces...
@djairjr
Update pins.c
54b6d3d 
Added objtuple to detect camera data tuple
@djairjr
Update pins.c
aea5d14 
Correcting CAM_HREF pin from 37 to 47
@djairjr
Update pins.c
f2474ab 
Correcting UART Pins too
@djairjr
Update pins.c
7c08182
@djairjr
Update board.c
d037b9a 
Trying to deal with errors when creating espcamera object
@djairjr
Update mpconfigboard.mk
5bfb55f 
Added Audiobusio to mic support?
@djairjr
Update sdkconfig
531a931 
Adding Camera Configs. Copyied from adafruit_esp32s3_camera
@djairjr
Update sdkconfig
b3c53af
@djairjr
Update pins.c
bf3c7b1
@djairjr
Merge branch 'adafruit:main' into seeed_xiao_esp32s3
f971a93
@djairjr
Copy link
Author

djairjr commented Aug 18, 2024

Okay, guys. I have now got a working version for the board. I tested the camera with the Xiao Round Display and everything works great.
The problem with the USB_PID and USB_VID still needs to be addressed and this is preventing my changes from being included.

But I'll see about that with Seeed.

Running USB VID/PID and Creator/Creation ID Duplicate Checker...
Duplicate VID/PID usage found!
- VID/PID: 0x303A:0x80D1
 Boards: seeed_xiao_esp32_s3_sense, unexpectedmaker_tinys3
If you are open source maker, then you can request a PID from http://pid.codes
For boards without native USB, you can request a Creator ID from https://github.com/creationid/creators/
Otherwise, companies should pay the USB-IF for a vendor ID: https://www.usb.org/getting-vendor-id
FAQ: Why does CircuitPython require a unique VID:PID for every board definition? https://learn.adafruit.com/how-to-add-a-new-board-to-circuitpython/frequently-asked-questions#faq-3130480

@djairjr
Copy link
Author

djairjr commented Aug 18, 2024

You can test here: https://github.com/djairjr/Seeed_Xiao_ESPS3_Sense_Circuitpython

djairjr added 6 commits August 19, 2024 10:52
@djairjr
Update mpconfigboard.mk
804ecec 
Remove comment in audiobusio line
@djairjr
Update mpconfigboard.mk
f31e3ad 
Added correct VID and PID based on this response:
adafruit#9507 (comment)
@djairjr
Merge branch 'adafruit:main' into seeed_xiao_esp32s3
5638526
@djairjr
Update board.c
febe52f 
Updated header.
@djairjr
Update mpconfigboard.h
228c132 
Updated header.
@djairjr
Update pins.c
42216a6 
Updated header
djairjr added 4 commits August 26, 2024 15:18
@djairjr
Merge branch 'adafruit:main' into seeed_xiao_esp32s3
25580ae
@djairjr
Update pins.c
98ab3bf 
Removing some comments in same line as commands.
@djairjr
Update pins.c
289404a 
Trying (again) to remove white spaces... Geez!
@djairjr
Update pins.c
f3443ef 
Remove White Spaces?
@dhalbert dhalbert requested review from tannewt and dhalbert September 2, 2024 19:56
dhalbert
dhalbert approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this looks good to me. @deshipu and @tannewt are you ok with this?

tannewt
tannewt approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

@tannewt tannewt merged commit 8df4942 into adafruit:main Sep 3, 2024
12 checks passed
@djairjr djairjr deleted the seeed_xiao_esp32s3 branch September 3, 2024 19:33
@djairjr
Copy link
Author

djairjr commented Sep 9, 2024

When will it be possible to download the firmware from the download page? What are the next steps?

@dhalbert
Copy link
Collaborator

dhalbert commented Sep 9, 2024

When will it be possible to download the firmware from the download page? What are the next steps?

The builds are already in AWS: https://adafruit-circuit-python.s3.amazonaws.com/index.html?prefix=bin/seeed_xiao_esp32_s3_sense/. When we make make another 9.2.0-alpha release, then the circuitpython.org page will get updated.

@dhalbert
Copy link
Collaborator

dhalbert commented Oct 23, 2024 •
edited
Loading

@djairjr Could you post more info and maybe a link about where you got the USB PID from? It looks like you got it from Seeed. We want to add the base board as well, without the camera, and it should probably have a separate PID.

@djairjr
Copy link
Author

djairjr commented Oct 23, 2024 •
edited
Loading

@dhalbert , i've got the USB/PID and VID in this message: #9507 (comment)
with @marcobrianza

The email for support team is: techsupport@seeed.io

@dhalbert dhalbert mentioned this pull request Dec 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deshipu deshipu deshipu left review comments

@dhalbert dhalbert dhalbert approved these changes

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djairjr @dhalbert @tannewt @deshipu