Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to IDF 5.3 #9526

Merged
merged 7 commits into from
Aug 16, 2024
Merged

Update to IDF 5.3 #9526

merged 7 commits into from
Aug 16, 2024

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Aug 15, 2024

The Funhouse problem was due to a locking change for SPI. The Funhouse is one of a few boards with DotStar status LEDs that use SPI and have this bug.

I thought it might be IDF related so I updated it first. :-)

This was meant to fix #9486, but it doesn't however, it has other useful fixes.

The Funhouse problem was due to a locking change for SPI. The
Funhouse is one of a few boards with DotStar status LEDs that use
SPI and have this bug.

I thought it might be IDF related so I updated it first. :-)

Fixes micropython#9486
@tannewt tannewt requested a review from dhalbert August 15, 2024 18:37
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing:

Metro ESP32-S3: simple BLE and WiFi HTTPS requests worked fine.

FunHouse: originally I couldn't get it to come up with serial or CIRCUITPY. I erased the FunHouse and reloaded the UF2 bootloader, and at first it was fine. But then it failed again. To reproduce, erase and load .bin, or load TinyUF2 and the .uf2. It will come up, but if you do import wifi, it hangs or crashes, with no output. If a settings.toml is present, the status line will come up with No IP, and again, no serial or CIRCUITPY, indicating a crash or hang.

@dhalbert
Copy link
Collaborator

More testing:

Metro ESP32-S2: this has the same ESP32-S2 WROVER module as the FunHouse. Erased completely, loaded .bin. import wifi does not crash. Copied over settings.toml with CIRCUITPY_WIFI_*, values, comes up, and reports an IP in the status line.

So again the problem seems to be FunHouse specific.

I could go ahead and merge this and you could keep working on FunHouse, if that makes sense.

@dhalbert dhalbert changed the title Fix Funhouse and update to IDF 5.3 Update to IDF 5.3 Aug 16, 2024
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging to get the other changes in, and @tannewt will look at #9486 again.

@dhalbert dhalbert merged commit 830294e into adafruit:main Aug 16, 2024
325 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FunHouse flashes Yellow lights then nothing, won't boot after installing circuitpython v9.1.1
2 participants