-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
picodvi: support 640x240 and 800x240 (tested @1bpp) #9102
Conversation
and dynamically calculate dvi_vertical_repeat the 640x240 mode was useful for a little project of mine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment on one thing I don't understand.
Could you test this against some existing working cases to check for regression? Thanks.
Were you able to test this on an older working test case? Thanks. I just want to make sure there is no regression due to the new code further down in the change. |
I tested the following modes:
the 400x240@8bpp mode would not initialize:
This allocation is the framebuffer of 96000 bytes plus the "TDMS buffers":
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
and dynamically calculate dvi_vertical_repeat
the 640x240 mode was useful for a little project of mine